Fix valid youtube error

Describe When embedding a youtube video on a page we may get MISSING_EMBED_PERMISSION error, which is not in the enum type here. This results to the event being invalidated as well (schema). As discussed with @greg-el , there seems to be a mismatch with the error codes mapping here.

To Reproduce Probably by embedding a youtube video without embed permissions.

Expected behavior The event with the youtube error being valid.

Additional context The corresponding youtube schema may need to be patched as well.

[igneel64]

Yeap that is Option 1 in a nutshell! (I might have messed up what changes are needed in each option)

All in all, we just change the mapping to fit the current schema.

[adatzer]

Got it now! 💡 Thank you!

Ok, one more question: Isn’t the choice of strings ours? I mean, aren’t the error codes(numbers) the only thing we get from the youtube API? Or do we also get the strings (e.g. INVALID_URL) as message?

What if we just change Map 1,

from:

2: 'INVALID_URL',
5: 'HTML5_ERROR',
100: 'VIDEO_NOT_FOUND',
101: 'MISSING_EMBED_PERMISSION',
150: 'MISSING_EMBED_PERMISSION',

to:

2: 'INVALID_PARAMETER',
5: 'HTML5_PLAYER_ERROR',
100: 'NOT_FOUND',
101: 'EMBED_DISALLOWED',
150: 'EMBED_DISALLOWED',

and keep only that (plus no schema change)?