question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Scala Stream Collector: move cross domain configuration to enabled-style

See original GitHub issue

At the moment, there are configurations which are defined as:

x {
  enabled = true/false
  restOfTheConfig = ...
}

and others defined as:

x {
  restOfTheConfig = ...
}

and its presence or absence determines if the feature is used.

We should pick one and stick to it.

I tend to prefer the second one as less stuff you don’t care about gets in your way.

wdyt @chuwy @alexanderdean ?

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:6 (6 by maintainers)

github_iconTop GitHub Comments

1reaction
chuwycommented, Feb 16, 2018

At least in JSON configurations we prefer first approach (even have linter for that). I also think that first approach is more explicit.

0reactions
alexanderdeancommented, Mar 14, 2018

Not sure. Your call.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Scala Stream Collector: restrict Access-Control-Allow-Origin to ...
This would work as follows: provide a list of domains as configuration if the origin header from the request is one of the...
Read more >
Configure the Stream Collector - Snowplow Documentation
Configure the Stream Collector. This is a complete list of the options that can be configured in the collector HOCON config file.
Read more >
snowplow collector is not working with https protocol (port 443)
This file (config.hocon.sample) contains a template with # configuration options for the Scala Stream Collector.
Read more >
snowplow/scala-stream-collector-pubsub:2.1.1-rc2 - Docker Hub
snowplow/scala-stream-collector-pubsub:2.1.1-rc2 ... ENV SNOWPLOW_CONFIG_PATH=/snowplow/config SNOWPLOW_BIN_PATH=/snowplow/bin.
Read more >
(PDF) ubiREST: A RESTful Service-oriented Middleware for ...
Work related to ubiREST ranges different research areas from multi-radio networks. integration to ubiquitous computing and service ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found