Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Make core classes final

See original GitHub issue

Is there any reason classes like AdapterDelegatesManager are not final? They really do not look like they are built for inheritance.

Issue Analytics

State:
Created 6 years ago
Comments:5 (5 by maintainers)

Top GitHub Comments

2reactions

PaulWoitaschekcommented, May 24, 2017

I’d like to see a usecase where overwriting makes sense. I think that if you overwrite something right now you are speculating about the internal implementation.

0reactions

veyndancommented, May 23, 2017

If you set the implementation detail methods to final, wouldn’t it just be preferable to set the whole class to final and favour composition over inheritance?

Top Results From Across the Web

CORe Grading Overview - HBS Online

Your CORe final exam score (50% of final course grade), ... Demonstrate a superior level of mastery of course content; Make exemplary contributions...

Core Courses - NCAA.org

Division I schools allow you to complete one additional core-course unit after you graduate high school, as long as you graduate in eight ......

Core Course of Study - The Glossary of Education Reform -

In high schools, a core course of study will typically include specified classes in the four “core” subject areas—English language arts, math, ...

A USER'S GUIDE TO THE UNIVERSITY CORE CURRICULUM

Core curriculum lays the foundation for a liberal education, giving students the skills they need to succeed in their disciplinary courses.

SAS Core Curriculum - SAS Advising - Rutgers University

The School of Arts and Sciences (SAS) requires that all students complete a goal-based Core Curriculum, as well as an approved major and...