GenerateId not working on 3x

I want to:

• report a bug
• request a feature

Current behaviour

When setting io.engine.generateId in v2.3.0, socket ids are set accordingly. In 3x (tested on 3.0.0 and 3.0.3) they are not.

Steps to reproduce

In Node.js:

const express = require('express');
const app = express();
const server = require('http').Server(app);
const io = require('socket.io')(server);
const { v4: uuidv4 } = require('uuid');

io.engine.generateId = function (req)
{
    return uuidv4();
}

Expected behaviour

As working in v2.3.0, the expected format of the socket ids should be, in this case, “xxxxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx”, being x alphanumerical. Instead I get the default socket id format.

Setup

• OS: Windows 10, running on Node.js
• socket.io version: 3.0.0 and 3.0.3

Other information (e.g. stacktraces, related issues, suggestions how to fix)

No errors are thrown, the format is simply not set.

[BrianHVB]

@darrachequesne - Oops, yes, that does. Thank you.

[betooo0997]

Oh, okay! Thanks for the info.

I was reusing the id to transmit it to other clients for video calls using peer.js, but peer.js doesn’t like its format.

But I just saw in the commit that you mentioned that I shouldn’t be doing this for security reasons, so I guess I can close this issue.

Thanks!