No CORS headers are set on the client javascript file

You want to:

• report a bug
• request a feature

Current behaviour

When serving the client via settings the serveClient option, the client is not served with the same CORS headers as the actual socket.io server.

Steps to reproduce (if the current behaviour is a bug)

Start a server with serveClient: true and request /socket.io/socket.io.js with an Origin header set.

Observe that the response does not have any Access-Control-Allow-Origin header set.

Expected behaviour

That the response has the same CORS headers as the normal operation.

Other information (e.g. stacktraces, related issues, suggestions how to fix)

This function (and the corresponding serveMap) should do the same origin checking as this code.

[eltharynd]

Is it me or CORS don’t have to be “set” on client side… you have to tell the server which cors will be accepted.

Here’s my implementation to allow all in typescript

this.app.use(cors({
    origin: '*',
    optionsSuccessStatus: 200,
}))

the browser is responsible for indicating the origin domain and you have no control over that for security reasons…

I might be mistaken…

Also, even if, this should probably go on the socket.io-client github 😃

[darrachequesne]

@bilalsha sure!