Reanimated module is not initialized when a class that implements the RCTBridgeDelegate Protocol is used

Description

Reanimated module is not initialized when a class that implements the RCTBridgeDelegate Protocol is used (e.g. when dependency injections are needed/brownfield apps). App throws undefined is not an object (evaluating 'InnerNativeModule.installCoreFunctions')

When a class that implements the RCTBridgeDelegate Protocol is used, jsExecutorFactoryForBridge in UIResponder+Reanimated.mm is never called.

My understanding is this happens because this condition

    if ([self.delegate conformsToProtocol:@protocol(RCTCxxBridgeDelegate)]) {

in RCTCxxBridge.mm is not satisfied and [cxxDelegate jsExecutorFactoryForBridge:self] is not called here.

Expected behavior

Reanimated module is initialized.

Actual behavior & steps to reproduce

Module is not initialized and App crashes with undefined is not an object (evaluating 'InnerNativeModule.installCoreFunctions'). Please see link to the fork of reanimated 2 playground below to reporoduce

Snack or minimal code example

fork of reanimated 2 playground that demonstrates the issue (branch name delegate_bridge)

Package versions

• React Native: 0.65.1
• React Native Reanimated: 2.3.0-beta.1 (also tested on 2.3.1, 2.2.4)
• NodeJS: 14.18.0
• Xcode: 13.1
• Java & Gradle: not relevant

Affected platforms

• Android
• iOS
• Web

[dov11]

The module will autoinstall if the class that implements the RCTBridgeDelegate Protocol is a subclass of UIResponder. E.g. in the example fork above:

ClassThatImplementsRCTBridgeDelegate : UIResponder

Alternatively, Reanimated can be patched with patch-package:

diff --git a/node_modules/react-native-reanimated/ios/native/UIResponder+Reanimated.h b/node_modules/react-native-reanimated/ios/native/UIResponder+Reanimated.h
index 3ee3797..0805b0d 100644
--- a/node_modules/react-native-reanimated/ios/native/UIResponder+Reanimated.h
+++ b/node_modules/react-native-reanimated/ios/native/UIResponder+Reanimated.h
@@ -3,7 +3,7 @@
 
 #ifndef DONT_AUTOINSTALL_REANIMATED
 
-@interface UIResponder (Reanimated) <RCTCxxBridgeDelegate>
+@interface NSObject (Reanimated) <RCTCxxBridgeDelegate>
 
 @end
 
diff --git a/node_modules/react-native-reanimated/ios/native/UIResponder+Reanimated.mm b/node_modules/react-native-reanimated/ios/native/UIResponder+Reanimated.mm
index 28c9262..a815e12 100644
--- a/node_modules/react-native-reanimated/ios/native/UIResponder+Reanimated.mm
+++ b/node_modules/react-native-reanimated/ios/native/UIResponder+Reanimated.mm
@@ -15,7 +15,7 @@
 
 #ifndef DONT_AUTOINSTALL_REANIMATED
 
-@implementation UIResponder (Reanimated)
+@implementation NSObject (Reanimated)
 - (std::unique_ptr<facebook::react::JSExecutorFactory>)jsExecutorFactoryForBridge:(RCTBridge *)bridge
 {
   const auto installer = reanimated::REAJSIExecutorRuntimeInstaller(bridge, NULL);

[adrianha]

just created new repo (init with RN 0.69 + Reanimated 2.9.1) to repro this issue:

• main: bridge initiated in AppDelegate –> Reanimated works fine
• custom-bridge: bridge initiated outside of AppDelegate –> throws TypeError: undefined is not an object (evaluating 'this.InnerNativeModule.installCoreFunctions')