Changes needed for gradle 3.0.1 compatibility

Some minor changes are needed for gradle 3.0.1 compatibility: in android/build.gradle:

• Remove the buildToolsVersion, gradle now specifies a default and the current value conflicts with that.
• Declare dependencies using api not compile per https://developer.android.com/studio/build/gradle-plugin-3-0-0-migration.html#new_configurations

We are currently hacking these changes with a script in status.im, and would rather it is fixed upstream. Thanks!

Parent issue: https://github.com/status-im/status-react/issues/3037

[pacamara]

@jskidd3 Sure, here’s the diff of the changes I needed for a fresh project:

FooProj $ git diff
diff --git a/android/build.gradle b/android/build.gradle
index eed9972..965bebb 100644
--- a/android/build.gradle
+++ b/android/build.gradle
@@ -2,10 +2,11 @@
 
 buildscript {
     repositories {
+        google()
         jcenter()
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:2.2.3'
+        classpath 'com.android.tools.build:gradle:3.0.1'
 
         // NOTE: Do not place your application dependencies here; they belong
         // in the individual module build.gradle files
diff --git a/android/gradle/wrapper/gradle-wrapper.properties b/android/gradle/wrapper/gradle-wrapper.properties
index dbdc05d..bf1b63c 100644
--- a/android/gradle/wrapper/gradle-wrapper.properties
+++ b/android/gradle/wrapper/gradle-wrapper.properties
@@ -2,4 +2,4 @@ distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-2.14.1-all.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-4.1-all.zip

Installed and ran ok after I also manually created the assets bundle (don’t believe this step has anything to do with gradle upgrade).

[msand]

Made a PR https://github.com/facebook/react-native/pull/17747