[BUG] The CairoSerializer cannot handle names starting with a underscore

I’ve a Cairo contract using names starting with a underscore. And using the FunctionCallSerializer for get back data from Cairo to Python (to decode transactions return data) will raise:

ValueError: Field names cannot start with an underscore: '_name`

It’s a namedtuple limitation, from here: https://github.com/software-mansion/starknet.py/blob/36acd9f75e189b94a75ac413f99e72984d1e3121/starknet_py/utils/data_transformer/data_transformer.py#L207-L209

Python version

All.

Expected Behavior

Names starting with a underscore should not be a problem.

Current Behavior

ValueError: Field names cannot start with an underscore: '_name`

Possible Solution

1. We could use the rename kwargs from the namedtuple, but will would loose the real name then.
2. An idea using dataclasses, but we would then loose the tuple comparison (which is mandatory to keep):

 from dataclasses import make_dataclass

 # instead of the namedtuple:
 result = make_dataclass("Result", [(k, v) for k, v in ...], order=True, frozen=True, slots=True)

1. 💟 https://github.com/ksamuel/drecord

Steps to Reproduce

1. Use a name starting with a underscore, in any Cairo method.
2. Use FunctionCallSerializer.to_python().
3. See the exception.

Context (Environment)

The issue is quite big, because we’re using the FunctionCallSerializer in the Ape StarkNet plugin to decode transactions return data. The goal is to leverage all the fantastic work you’ve already done to decode all kind of data types (like arrays, and custom complex structs).

Detailed Description

Possible Implementation

I like the 3^rd idea. If you think it’s something you would like to implement, I could give a try.

[ca11ab1e]

Oh OK 😃 I know that FunctionCallSerializer calls CairoSerializer under the wood, and as FunctionCallSerializer is the new DataTransformer name, I used it. But yes, both have the same issue at the end.

[Arcticae]

Or me if he’s too busy 😉