question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

ffe-core doesn't export ES5

See original GitHub issue

Which package is this issue related to?

ffe-core

Describe your issue (screenshots welcome!)

When we build ffe-core, it creates some javascript files for variables, which can be imported. Unfortunately, the index file contains a trailing comma for functions, which are not ES5.

This leads to the build process failing whenever you use tools such as create-react-app.

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
ivarnicommented, Jun 18, 2018

That’s exactly what I’m suggesting you do 😃 Running it through babel ensures that it’s ES5 and noone forgets what’s in which spec and adds something that is not ES5 later.

0reactions
selbekkcommented, Jun 18, 2018

Fair enough, I don’t mind adding Babel to the build process

Read more comments on GitHub >

github_iconTop Results From Across the Web

ES5 exported function not recognized - Stack Overflow
There are two problems: This line probably doesn't do what you think it does: export default { sum, mul }. You're mixing native...
Read more >
Module Exports and Loading: ES5 to ES6 | by Zach Gavin
So how were module.exports and require working to share code between ... making it the default export does not give it any distinguishing ......
Read more >
ES6 Import & Export > Webpack Encore - SymfonyCasts
In reality, this still seems a bit buggy: the unused code doesn't always get removed. But, the point is this: import and export...
Read more >
ES5 Exports No Longer Colored Properly #59055 - GitHub
The preferred pattern for es5 exports is no longer colored properly. I expect this to either: Be colored properly. Allow for switching code ......
Read more >
Porting a Large ES5 JavaScript Library to ES6 Modules and ...
Only what is necessary is exported from modules (and the overall engine). But what about IE11? It doesn't understand ES6 module syntax!
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found