Meta errors when rendering multiple times concurrently
See original GitHub issueVersion: 1.1.3
Our company have recently converted all our emails to heml, and have been loving its simplicity so far. All of the emails we’ve sent so far have been transactional, where we’ve only sent them one at a time, and it’s worked without a hitch. We’re now implementing a monthly report for our users which will be sent out in bulk, and we’re seeing errors in development.
The error trace is as follows:
TypeError: null is not iterable!
at module.exports.require.getIterator (/Users/admin/Documents/backend/node_modules/core-js/library/modules/core.get-iterator.js:5:42)
at Object.flush (/Users/admin/Documents/backend/node_modules/@heml/elements/build/Meta.js:60:54)
at _callee$ (/Users/admin/Documents/backend/node_modules/@heml/render/build/index.js:343:73)
at tryCatch (/Users/admin/Documents/backend/node_modules/regenerator-runtime/runtime.js:62:40)
at Generator.invoke [as _invoke] (/Users/admin/Documents/backend/node_modules/regenerator-runtime/runtime.js:296:22)
at Generator.prototype.(anonymous function) [as next] (/Users/admin/Documents/backend/node_modules/regenerator-runtime/runtime.js:114:21)
at step (/Users/admin/Documents/backend/node_modules/babel-runtime/helpers/asyncToGenerator.js:17:30)
at /Users/admin/Documents/backend/node_modules/babel-runtime/helpers/asyncToGenerator.js:28:13
This seems to be caused by Meta
- the metaMap
Map is being flushed on the first render (this line), then the null
Map is causing errors in subsequent renders.
Is there a preferred method to handle rendering multiple emails concurrently, or is this a bug? Happy to provide any more information if required - otherwise I suppose the quickest fix for us would be to build the emails in series.
Thanks, Ben Mansley
Issue Analytics
- State:
- Created 5 years ago
- Reactions:2
- Comments:7
Top GitHub Comments
I found a workaround. I actually build with a script all my folder heml, into a folder html. Push both folders and in the code I directly load from the html folder (and for variables i use Mustache)
Script to build:
Load html email:
Build the emails with dynamic variables:
Hello, Got exactly the same problems when rendering emails to send to different customers in AWS lambda