Remaining arguments gets reparsed and split on spaces

Forked from spectresystems/spectre.cli#108 as requested

Scenario

My application wraps around execution of other applications so I need to pass all arguments as is, for example, this:

app run cmd -- /c "set && pause"

tells my app (app) to run (run) other application (cmd) and pass "other arguments “as is” (/c "set && pause"). I can see though that single argument “set && pause” get’s reparsed as 3 “set”, “&&”, and “pause” (in context.Remaining.Raw) and I lose all clues that it ever was a single one.

Code

class Program
{
	static void Main(string[] args)
	{
		var testArgs = new[] {
			"run",
			"cmd",
			"-e", "A=7",
			"-e", "B=10",
			"--",
			"/c", "set && pause"
		};
		var app = new CommandApp();
		app.Configure(config => config.AddCommand<RunCommand>("run"));
		app.Run(testArgs);
	}
}

public class RunCommand: Command<RunCommand.Settings>
{
	public class Settings: CommandSettings
	{
		[CommandArgument(0, "<EXECUTABLE>")]
		public string Executable { get; set; } = null!;

		[CommandOption("-e <VAR=VAL>")]
		public string[] Environment { get; set; } = Array.Empty<string>();
	}

	public override int Execute(CommandContext context, Settings settings)
	{
		Console.WriteLine(JsonConvert.SerializeObject(settings));
		Console.WriteLine(JsonConvert.SerializeObject(new {
			Parsed = context.Remaining.Parsed.ToArray(),
			Raw = context.Remaining.Raw.ToArray()
		}));
		return 0;
	}
}

Expected

{"Executable":"cmd","Environment":["A=7","B=10"]}
{"Parsed":[],"Raw":["/c","set && pause"]}

Actual

{"Executable":"cmd","Environment":["A=7","B=10"]}
{"Parsed":[],"Raw":["/c","set","&&","pause"]}

(See: Raw array, expected 2 arguments, received 4 arguments)

[patriksvensson]

@MiloszKrajewski Btw, I notice that you’re trying to parse the form -e FOO=BAR -e BAZ=QUX. This is already supported. Just set the type of your Environment property to ILookup<string, string>, and it will be mapped automatically.

public class Settings : CommandSettings
{
	[CommandArgument(0, "<ARGUMENT>")]
	public string[] Arguments { get; set; } = null!;

	[CommandOption("-e <VAR=VAL>")]
	public ILookup<string, string> Environment { get; set; }
}

The types ILookup<string, string>, IDictionary<string, string> and IReadOnlyDictionary<string, string> will work here, but the two latter will, of course, not support multiple values for the same key.

[MiloszKrajewski]

Yes it is what I would expect. Although… I by accident discovered unrelated bug (I managed to freeze/infinite loop parser). I’ll create new issue (#186)