Changes to nlp clone still affects original nlp

Hi I’m trying to use multiple instances of nlp each with different plugins nlp.clone().extend(). However, since the world variable is global, any changes effect all nlp instances.

This can be seen by updating the following test and adding a copy of the first check to the end.

https://github.com/spencermountain/compromise/blob/51f1f158e6fcab14cdbf14f182b0c41f94e513e7/tests/plugin/addWords.test.js#L6-L8

test('persistent-lexicon-change', function(t) {
  let nlp2 = nlp.clone()
  let doc = nlp('he is marko')
  t.equal(doc.match('#Place+').length, 0, 'default-no-place')
  t.equal(doc.match('#Person+').length, 1, 'default-one-person')

  nlp2.extend((Doc, world) => {
    world.addWords({
      marko: 'Place',
    })
  })
  doc = nlp2('he is marko')
  t.equal(doc.match('#Place+').length, 1, 'now-one-place')
  t.equal(doc.match('#Person+').length, 0, 'now-no-person')

 // ....

  // Tests fail here - original nlp should not be affected?
  doc = nlp('he is marko')
  t.equal(doc.match('#Place+').length, 0, 'default-no-place')
  t.equal(doc.match('#Person+').length, 1, 'default-one-person')

  t.end()
})

Am I misunderstanding the intention behind the clone() function? Thanks in advance!

[Drache93]

True, but we’d only do it because a person specifically chose to make a fresh instance, so their choosing to using more memory 😄.

Maybe we just fix clone to create a fresh instance with cloned world? Breaking change if people are using it currently with the assumption changes go backwards. So no global world, and no new worlds. Just selective cloning. Again can always have a Boolean for empty clone.

[Drache93]

Haha 😄 .new feels weird in JS. Also it’s not original or default considering it’s still uses the global world (could always add a Boolean for totally fresh)

Shame clone is used 😄 copy()?

Edit: Maybe the global world thing is confusing. Maybe with argument or extra function the choices are: new nlp with world cloned from old one, or nlp with fresh world. No global extend/world.