Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Commas in whitespcae

See original GitHub issue

const result = compromise.nlp(`We just released, "Square Up".`);

const textArray = result.map(obj => obj.text);
console.log(textArray);
// ['We', 'just', 'released,', 'Square', 'Up"']

I think it should be one of either case: 1) the 4th element should be'"Square', or 2) the fifth element should be Up. As far as I know, this library’s text property is designed to include,, ", ‘`’ (https://github.com/spencermountain/compromise/blob/master/src/text/methods/normalize.js#L22). So, I believe it should have been the former case.

(Btw, is it correct that spaceBefore and spaceAfter contains quotation symbols? I’m asking this because the property is named as spaceXXX.)

Issue Analytics

State:
Created 5 years ago
Comments:7 (4 by maintainers)

Top GitHub Comments

1reaction

ohtangzacommented, Dec 6, 2019

@spencermountain Checked your message! Looks good now!

cc: @ghsdh3409

1reaction

spencermountaincommented, Dec 2, 2019

hey Jeungmin, this has been refactored in v12, and seems to make a little more sense:

const doc = nlp(`We just released, "Square Up".`)
console.log(doc.json({ terms: { whitespace: true } })[0])

/*{ text: 'We just released, "Square Up".',
  terms:
   [ { text: 'We', tags: [Array], pre: '', post: ' ' },
     { text: 'just', tags: [Array], pre: '', post: ' ' },
     { text: 'released', tags: [Array], pre: '', post: ', ' },
     { text: 'Square', tags: [Array], pre: '"', post: ' ' },
     { text: 'Up', tags: [Array], pre: '', post: '".' } ] }
*/

thanks for your patience.