Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

EndPunctuation regex fails

See original GitHub issue

The EndPunctuation‘s regex endPunct does not allow a space : /([a-z])([,:;\/.(\.\.\.)\!\?]+)$/i; in https://github.com/nlp-compromise/compromise/blob/df050d5be8994f4124274f3bfc84e4ff61814e83/src/term/methods/punctuation.js

That means for example “Who is Boris Becker ?” has no EndPunctuation and is not detected as a question because when I look at the questions subset, questions must have a ? as EndPunctuation :

let list = r.list.filter(ts => {
    return ts.last().endPunctuation() === '?';
});

Issue Analytics

State:
Created 6 years ago
Comments:8 (8 by maintainers)

Top GitHub Comments

1reaction

sebilassecommented, Aug 22, 2017

Found it out - the regex endPunct should be const endPunct = /([^\/,:;.()!?]{0,1})([\/,:;.()!?]+)$/i;

to allow for spaces and combinations as in “Is Trump a fool or the president of U.S. ?”

0reactions

spencermountaincommented, Oct 24, 2017

hey, just cleaning up tasks, gonna close this. nlp(' U.S. ? ') is a edge-case i’m willing to let us waffle on for now. cheers!

Top Results From Across the Web

Regex - Ignore punctuation at end of string - Stack Overflow

Regex - Ignore punctuation at end of string ... I am using regex to match strings, here is my code: r = re.compile(r"#?%s\b"...

bash - How to match end of last string in file which does not ...

I'm trying to list the file name with the final ascii character which is not followed by period/ punctuation. I've looked all over...

Remove all the punctuation marks from a sentence using RegEx

Given a text/string, remove all the punctuation marks from the string/text using regex. The string can have alphabets, spaces, punctuations, and numbers.

Best Practices for Regular Expressions in .NET - Microsoft Learn

Consider the input source. In general, regular expressions can accept two types of input: constrained or unconstrained.

Matches a word at the end of a string, with optional punctuation

Python Exercises, Practice and Solution: Write a Python program that matches a word at the end of a string, with optional punctuation.