Please provide build instructions that do as little as possible on the host machine

Reading the 4.1.5 build instructions for Android I’m supposed to run the 68 LOC contrib/android/build.sh which calls the 154 LOC contrib/build_tools_util.sh and it even requires sudo root access.

I compile a lot of APKs for WalletScrutiny.com and no other requires this. Can’t that be encapsulated in the Docker scripts so I can run Docker (without root) and it does what it needs to do inside the container?

I’d like to automate reproducibility testing but am reluctant running those scripts as root or actually anything but inside docker containers without a careful review after any change.

[SomberNight]

So for my purpose, this issue can be closed. I’m not sure if others have the same concerns when reproducing a binary.

Ok, especially if it’s not that important, I don’t actually have much time to look into removing the sudo usage… However, if someone is interested, please have a look. I’ll close this issue though.

[Giszmo]

That’s great. So my script should work just fine, stripping a final “.0” from the versionName.

My perspective is not “Is the build process deterministic”, starting from git. My perspective is “There’s an apk on Google Play. Can I reproduce it?”, so I unpack the apk, figure out the appId and versionName and go from there.

(It cannot easily be removed as the toolchain we use, python-for-android, calculates the apk versionCode from the versionName.)

You could add a secondary tag that contains that .0. Maybe even make it android-v4.1.5.0 but again, for my needs no changes are necessary. Stripping the .0 is easy enough.