Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Sponge 5.2.0 & Pokecube Dupe

See original GitHub issue

I am currently running…

SpongeForge version: spongeforge-1.10.2-2281-5.2.0-BETA-2433.jar
Forge version: forge-1.10.2-12.18.3.2281-universal.jar
Java version: 1.8.0_131
Operating System:

Linux (Ubuntu, Debian, Fedora, etc)
macOS
Windows

Plugins/Mods: spongeforge-1.10.2-2281-5.2.0-BETA-2433.jar Pokecube Core-4.31.0.jar Pokecube Mobs-2.10.0.jar Pokecube Revival-4.20.0.jar pokecubeserverutils-1.4.0.jar thutcore-3.16.0.jar

What is the expected result? Pokecube must go into PC, and didn’t dupe in my hands. What is the current result? Running this mod without sponge, all ok no dupe, running with sponge have 2 pokecubes, 1 in PC, another still in inventory

logs.zip

2017-07-24_18 33 14 2017-07-24_18 33 15 2017-07-24_18 33 19

Issue Analytics

State:
Created 6 years ago
Comments:13 (5 by maintainers)

Top GitHub Comments

1reaction

Zidanecommented, Jul 27, 2017

I slept on this @Thutmose and I agree. We are incorrectly putting the stack back in the inventory on cancel.

Originally I imagine our thought process was people wanting to stop an ItemToss and preserve inventory but that is easily fixed by firing a Pre event on our end for our plugins. If not cancelled, it then goes into ItemTossEvent then into SpawnEntityEvent for the EntityItem (should ItemToss not be cancelled).

@gabizou we need to investigate getting such an event added to address this.

0reactions

Snez0kRUcommented, Jul 27, 2017

@bloodmc I’m tested this, and i confirm that issue is fixed in latest SF. Thanks a lot comrades