Exception is not logged when pulling

We are using spring-cloud-config 1.1.0.M3, and currently repeatedly see a warning being logged: Could not pull remote for master (current ref=Ref[refs/heads/master=386bfc56eb3b12de6e638db20180aedabcdef]), remote: [e-mail]:company/config.git

However, since the Exception is not logged it makes it more difficult to find the actual cause of the problem.

Therefore I would like to propose the following change at JGitEnvironmentRepository, line 220:

catch (Exception e) {
    this.logger.warn("Could not pull remote for " + label + " (current ref=" + ref
            + "), remote: " + git.getRepository().getConfig().getString("remote",
            "origin", "url"));
}

change to:

               catch (Exception e) {
            this.logger.warn("Could not pull remote for " + label + " (current ref=" + ref
                    + "), remote: " + git.getRepository().getConfig().getString("remote",
                            "origin", "url"), e);
        }

[skhome]

I would like to see the error logging being improved as well.

We faced a similar problem which we were not able to track down to it’s root cause. We had an exception being thrown at the place mentioned above and suspected also an exception being thrown in MultipleJGitEnvironmentRepository#getLocations but the

catch (Exception e) {
    continue;
}

did hide the root cause.

While I totally agree that the config-server should be as resilient as possible and should rather serve requests from a local potentially stale cache then not at all, having more information available to fix the root cause would be helpful.

[tjuchniewicz]

I agree with @skhome. It would be great to log (even in DEBUG without stacktrace for me) error in MultipleJGitEnvironmentRepository#getLocations

catch (Exception e) {
    continue;
}

Now the only way for me to find root cause was debugging.