BlockingLoadBalancerClient does not work with KubernetesDiscoveryClient

Hi,

I’m trying to migrate from ribbon LB to newly introduced blocking LB.

Here is a test replicating the issue:

    @Test
    public void testReconstructURIForK8S() {
        ServiceInstance instance = new KubernetesServiceInstance("auth-server", "auth-server",
                new EndpointAddress("hostname", "127.0.0.1", "nodeName", null),
                new EndpointPort("http", 8091, "tcp"),
                Collections.emptyMap(),
                false);
        URI uri = LoadBalancerUriTools.reconstructURI(new TruncateSchemaServiceInstance(instance),
                URI.create("http://auth-server/oauth/token"));

        assertThat(uri.toString()).isEqualTo("http://127.0.0.1:8091/oauth/token");
    }

Fails with:

   001:  "java.lang.IllegalStateException: Could not create URI object: Expected hostname at index 7: http://://127.0.0.1:8091/oauth/token"     
   002:  "at org.springframework.web.util.HierarchicalUriComponents.toUri(HierarchicalUriComponents.java:514)"     
   003:  "at org.springframework.cloud.client.loadbalancer.LoadBalancerUriTools.doReconstructURI(LoadBalancerUriTools.java:111)"     
   004:  "at org.springframework.cloud.client.loadbalancer.LoadBalancerUriTools.reconstructURI(LoadBalancerUriTools.java:95)"     
   005:  "at org.springframework.cloud.loadbalancer.blocking.client.BlockingLoadBalancerClient.reconstructURI(BlockingLoadBalancerClient.java:75)"     
   006:  "at org.springframework.cloud.client.loadbalancer.ServiceRequestWrapper.getURI(ServiceRequestWrapper.java:43)"     
   007:  "at org.springframework.http.client.InterceptingClientHttpRequest$InterceptingRequestExecution.execute(InterceptingClientHttpRequest.java:97)"     
   008:  "at org.springframework.cloud.client.loadbalancer.LoadBalancerRequestFactory.lambda$createRequest$0(LoadBalancerRequestFactory.java:61)"     
   009:  "at org.springframework.cloud.loadbalancer.blocking.client.BlockingLoadBalancerClient.execute(BlockingLoadBalancerClient.java:62)"     

The issue is that KubernetesServiceInstance returns for schema either “http://” or “https://”. Current implementation of LoadBalancerUriTools except schema to be “http” or “https”.

I’ve checked implementation of ServiceIntance for Eureka, it returns null when getSchema is called.

Should we fix issue in KubernetesServiceInstance or adjust LoadBalancerUriTools to trim “😕/” during URI reconstruction? (second one looks more safe).

Thanks, Artyom

[spencergibb]

Wait, why can’t we fix kubernetes service instance? I don’t want work around in a common library for this one’s bug.

[ArtyomGabeev]

Hi, @TYsewyn @spencergibb Are we waiting for next major release to get it merged?

Thanks