The problem occurs when you have two or more namespaces, where the service name is the same

The problem occurs when you have two or more namespaces, where the service name is the same. Example: service ‘price’ is in namespaces ns1 and ns2 in the same cluster kubernetes.

xxx-service.yaml

metadata:
   namespace: ns1
   name: price
   labels:
       app: price
       group.department: dept1

yyy-service.yaml

metadata:
  namespace: ns2
  name: price
  labels:
      app: price
      group.department: dept2
	  

app-discovery.yaml

spring:
  cloud:
    kubernetes:
	discovery:
	  service-labels:
	  - group.department: dept1

In this case, the current code returns the endpoints of both namespaces, which is not expected. To resolve this issue you have to apply the service-labels filter, .withLabels(serviceLabels).

spring-cloud-kubernetes, version:1.0.4.BUILD-SNAPSHOT

package org.springframework.cloud.kubernetes.discovery;
public class KubernetesDiscoveryClient implements DiscoveryClient {
  ...
	@Override
	public List<ServiceInstance> getInstances(String serviceId) {
		...
		// bug
		// List<Endpoints> endpointsList = this.properties.isAllNamespaces()
		//	? this.client.endpoints().inAnyNamespace().withField("metadata.name", serviceId).list().getItems()
		//	: Collections.singletonList(this.client.endpoints().withName(serviceId).get());

		//adjusted
		Map<String, String> serviceLabels = properties.getServiceLabels();
		List<Endpoints> endpointsList = properties.isAllNamespaces() ?
				client.endpoints().inAnyNamespace().withField("metadata.name", serviceId).withLabels(serviceLabels).list().getItems()
				: Collections.singletonList(client.endpoints().withName(serviceId).get());
	}			
}

[m-kay]

I think there is not only a problem with the serivce label filter but more a general problem when spring.cloud.kubernetes.discovery.all-namespaces is set to true. Since in Kubernetes you can access the services by <namespace>.<service-name> this should also be reflected in the serviceId of the discovery client. I’m facing the problem in Spring Boot Admin where services with the same name but in different namespaces are shown as one service.

[junneyang]

In the discovery client you can now get the namespace information from each service instace with KubernetesServiceInstance#getNamespace(), if spring.cloud.kubernetes.discovery.all-namespaces is set to true.

so, how can i set the route, i want proxy request to someservice.namespaceA and someservice.namespaceB from different path(eg: /someservice.namespaceA/**, and /someservice.namespaceB/**)