question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

consider adding a bean name tag to async spans

See original GitHub issue

When eventually coming up with https://github.com/spring-cloud/spring-cloud-sleuth/pull/1464, we found it very hard to figure out which executor was causing “async” spans. Since the controls are based on bean name, it seems a decent idea to have a bean name tag. Ex spring.bean=fooExecutor

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Reactions:1
  • Comments:10 (6 by maintainers)

github_iconTop GitHub Comments

1reaction
marcingrzejszczakcommented, Aug 18, 2020

That’s a good idea. I’ll check it out today

0reactions
elefeintcommented, Aug 18, 2020

In ExecutorBeanPostProcessor.postProcessAfterInitialization(), the bean name is known. So it should be doable, although a bit annoying, to propagate the bean name through helper methods into TraceableExecutorService and TraceableScheduledExecutorService.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Using Spring Cloud Sleuth
There are 3 different ways to add tags to a span. All of them are controlled by the SpanTag annotation. The precedence is...
Read more >
Spring Cloud Sleuth - Single Application - Baeldung
This article focuses on using Spring Sleuth for tracing requests within a single application use cases.
Read more >
App is failing with "required a bean of type 'brave.Tracer' that ...
I am calling my Springboot app from another micro service to get the trace & span id's but getting error while starting the...
Read more >
Tracing In Microservices With Spring Cloud Sleuth - Ryan Baxter
Create a file called bootstrap.yml in src/main/resources . Within that file add the property spring.application.name and set it to whatever you ...
Read more >
OpenTracing - Apache Camel
<bean id="ottracer" class="org.apache.camel.opentracing. ... Camel context the Trace ID and Span ID will be added and removed from the MDC for each route...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found