Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Custom attributes in MDC are getting lost

See original GitHub issue

boot.zip Hi i am facing an issue where in custom attributes in MDC are getting lost when using config spring.sleuth.sampler.probability=1.0 Application log:-

2019-02-25 22:33:46.360  INFO [boot-1,aa5519088fb5bc53,aa5519088fb5bc53,true,10.20.30.40] 22508 --- [nio-2040-exec-1] c.s.study.controller.SampleControllerA   : SampleControllerA hello starts
2019-02-25 22:33:46.393  INFO [boot-1,aa5519088fb5bc53,bf4da017c8a86e69,true,10.20.30.40] 22508 --- [nio-2040-exec-2] c.s.study.controller.SampleControllerB   : SampleControllerB hi starts and ends
2019-02-25 22:33:46.422  INFO [boot-1,aa5519088fb5bc53,aa5519088fb5bc53,true,] 22508 --- [nio-2040-exec-1] c.s.study.controller.SampleControllerA   : SampleControllerA hello ends

After making a rest call trueclientip attribute in MDC is getting lost

Sample application code is attached

Issue Analytics

State:
Created 5 years ago
Comments:12 (2 by maintainers)

Top GitHub Comments

1reaction

mpkorstanjecommented, Feb 26, 2021

@marcingrzejszczak this no longer reproduceable with spring-cloud-sleuth:3.0.1. Feel free to close.

https://github.com/mpkorstanje/sleuth-custom-mdc-attributes-removed

0reactions

mpkorstanjecommented, Jan 4, 2021

I’m having trouble running your workaround though. I get a runtime exception on startup. I’m running Greenwich.RELEASE / Spring Boot 2.1.9.RELEASE if that matters.

Not a clue sorry.