Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
Should RateLimitingSampler be public?
See original GitHub issueI am trying to replicate* changes from SamplerAutoConfiguration autoconfiguration logic into spring-cloud-gcp, but RateLimitingSampler is package-private. Was it meant to be only package private, or is it okay to relax its visibility to public? ProbabilityBasedSampler, which is in the same package and is used similarly, is public already.
* I’d rather not replicate them at all and just rely on SamplerAutoConfiguration, but whenever TraceAutoConfiguration and SamplerAutoConfiguration are both present, TraceAutoConfiguration’s NEVER_SAMPLE sampler gets instantiated due to Spring Boot ordering (TraceAutoConfiguration has an order and SamplerAutoConfiguration does not, so SamplerAutoConfiguration is processed at the end). From the docs, NEVER_SAMPLE seems like intended behavior.
Issue Analytics
- State:
- Created 4 years ago
- Comments:6 (6 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
No added benefit whatsoever!
@AutoConfigureBefore(TraceAutoConfiguration.class)inSamplerAutoConfigurationwill be the perfect solution to our problem; then I can remove the custom sampler beans from StackdriverTraceAutoConfiguration for good.There’s no such property to disable a sampler. It doesn’t make much sense to have one.