Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
spring-cloud-sleuth-instrumentation sql issue for spans
See original GitHub issueDescribe the bug
Version: 3.1.0
The TraceListenerStrategy in spring-cloud-sleuth-instrumentation throws a StringOutOfBoundsException when the SQL consists of only one word, like: BEGIN. Such word, afaik, constitutes a valid SQL statement, and as such should be handled without throwing an exception.
The exception is thrown here:
https://github.com/spring-cloud/spring-cloud-sleuth/blob/main/spring-cloud-sleuth-instrumentation/src/main/java/org/springframework/cloud/sleuth/instrument/jdbc/TraceListenerStrategy.java#L432
(in spanName method), as indexOf(' ') is -1.
I’d suggest handling this with returning the whole SQL as span name in such case. Another option would be to ignore such SQL.
Sample N/A
Issue Analytics
- State:
- Created 2 years ago
- Comments:20 (20 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
@gavlyukovskiy sounds reasonable to me, I’m happy to make that change to PR if you think that would be a best way to go.
You can check the tentative release dates here https://github.com/spring-cloud/spring-cloud-release/milestones