question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Add an entry to HELP.md that explains the transformation applied to an illegal package name to make it legal

See original GitHub issue

If I use dashes in my artifact name (e.g. thymeleaf-live-reload) and I expand the “Options”, it shows something like com.company.thymeleaf-live-reload as ‘Package Name’, which is not a valid package name. Luckily, the generated package name is com.company.thymeleaflivereload so you get a correct package name. It would be good to also have it correct on the website itself.

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:5 (4 by maintainers)

github_iconTop GitHub Comments

2reactions
wilkinsonacommented, Sep 20, 2019

As things stand this is intentional. The rules are applied on the server-side to ensure consistent behaviour between all of the different clients (web UI, IDEs, Spring Boot CLI, curl/httpie). While the rules could be duplicated in the Web UI there are a couple of notable downsides that we have chosen to avoid by keeping everything server-side-only:

  1. There is a risk that the client-side rules and the server-side rules would get out of sync.
  2. The rules cannot be applied on the client-side consistently. They can’t be applied at all with curl and httpie and the others are either not within our control or they have very different release cycles to start.spring.io.

There are other places where this sort of server-side modification occurs. For example when the version of Java is downgraded. Our current plan for that is to add something to the HELP.md file that explains why that has happened. While the package name isn’t exactly the same, I am leaning towards doing nothing at all or taking a similar approach rather than trying to duplicate the rules.

Let’s see what the rest of the team thinks.

0reactions
snicollcommented, Dec 27, 2019

We’ve made great progress on https://github.com/spring-io/initializr/pull/1023. Unfortunately, the cleaning of the package name happens too soon for us to track it. It’s now also blocked by https://github.com/spring-io/initializr/issues/1045

Read more comments on GitHub >

github_iconTop Results From Across the Web

Keep track of the original `ProjectDescription` by onobc · Pull ...
Add an entry to HELP.md that explains the transformation applied to an illegal package name to make it legal spring-io/start.spring.io#276.
Read more >
8 Medical Coding Mistakes That Could Cost You
Physicians deserve to be paid for the medical care they provide. Learn more with the AMA about the CPT coding errors to avoid....
Read more >
javadoc doclet libs : Illegal package name or ... - Stack Overflow
Looking at your target path: ./all-libs/*.jar. This is not going to be a proper package name with hyphens in it unfortunately. You'll need...
Read more >
16-402 Carpenter v. United States (06/22/2018)
Carpenter moved to suppress the data, arguing that the Government's seizure of the records without obtaining a warrant supported by probable ...
Read more >
W3C XML Schema Definition Language (XSD) 1.1 Part 1
The purpose of an XSD schema is to define and describe a class of XML documents by using schema components to constrain and...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found