@EntityScan value attribute not evaluated anymore

Hello,

When upgrading to Spring Boot 1.4.0.RC1 from MS3, the value attribute of the org.springframework.boot.autoconfigure.domain.EntityScan annotation is not evaluated as expected.

This results in an exception:

@Configuration
@EntityScan(value = "my.base.entity.package")
public class PersistenceConfiguration {
  //...
}

However, this works:

@Configuration
@EntityScan(basePackages = "my.base.entity.package")
public class PersistenceConfiguration {
  //...
}

Exception cause is:

Caused by: java.lang.IllegalArgumentException: Not a managed type: class my.base.entity.package.MyEntity
    at org.hibernate.jpa.internal.metamodel.MetamodelImpl.managedType(MetamodelImpl.java:210) ~[hibernate-entitymanager-5.0.9.Final.jar:5.0.9.Final]
    at org.springframework.data.jpa.repository.support.JpaMetamodelEntityInformation.<init>(JpaMetamodelEntityInformation.java:68) ~[spring-data-jpa-1.10.2.RELEASE.jar:na]
    at org.springframework.data.jpa.repository.support.JpaEntityInformationSupport.getEntityInformation(JpaEntityInformationSupport.java:67) ~[spring-data-jpa-1.10.2.RELEASE.jar:na]
    at org.springframework.data.jpa.repository.support.JpaRepositoryFactory.getEntityInformation(JpaRepositoryFactory.java:152) ~[spring-data-jpa-1.10.2.RELEASE.jar:na]
    at org.springframework.data.jpa.repository.support.JpaRepositoryFactory.getTargetRepository(JpaRepositoryFactory.java:99) ~[spring-data-jpa-1.10.2.RELEASE.jar:na]
    at org.springframework.data.jpa.repository.support.JpaRepositoryFactory.getTargetRepository(JpaRepositoryFactory.java:81) ~[spring-data-jpa-1.10.2.RELEASE.jar:na]

From a quick debugging session, it seems to me that the evaluation of the value attribute is missing in org.springframework.boot.autoconfigure.domain.EntityScanPackages.Registrar#getPackagesToScan

[gbauer]

@snicoll Thanks for fixing this so quick. I’ll test it on Monday on the real-world project.

[bojan-milojkovic]

If you copy-pasted persistence configuration from another project, you must set the entity scan in EntityManagerFactory manually :

@Bean
public EntityManagerFactory entityManagerFactory() throws PropertyVetoException {
    LocalContainerEntityManagerFactoryBean factory = new LocalContainerEntityManagerFactoryBean();
    factory.setPackagesToScan("**misspelled.package.path.to.entities**");
    .....
}