Test fail: StringToInetAddressConverterTests relies on NSLookup

Bug Report Got a Test fail when building the current master.

StringToInetAddressConverterTests fails on my machine because it relies on the local nslookup. The test assumes that the host ireallydontexist.example.com is not known and therefore does throw an exception in InetAddress.getByName(source);.

Sadly my ISP’s has a strange default error page for DNS lookup errors and therefore that host does exist for me => I got a test fail.

Last screenshot is of a watch of the command which should throw that exception instead of returning the shown object.

Switching off my internet or changing the DNS to e.g. 8.8.8.8 does solve that issue.

Not sure if this is a real bug per se, just wanted to point it out. Would have liked to update it myself but I am a bit clueless since InetAddress is a system class and until now I know no possibility to update the nslookup from java directly for a specific hostname.

Any ideas / suggestions?

[eiselems]

Love the title of the commit message 😊 Well done

[philwebb]

Removing it doesn’t seem wise, but we could add an assume to ensure resolve will fail.