TestRestTemplate does the url encoding twice if I pass the URI as a string

Controller:

@RestController
@RequestMapping(value = "/uritest")
public class TestController {

    @RequestMapping(method = { RequestMethod.GET })
    public ResponseEntity<Void> endpoint(@RequestParam(required = true) String param) {
        System.out.println(param);
        return new ResponseEntity<>(HttpStatus.OK);
    }
}

Integration Test:

@ActiveProfiles("test")
@RunWith(SpringRunner.class)
@SpringBootTest(webEnvironment = WebEnvironment.DEFINED_PORT)
public class ControllerTest {

    @Autowired
    private TestRestTemplate testRestTemplate;

    @Rule
    public WireMockRule wireMockRule = new WireMockRule();

    HttpHeaders headers;

    @Test
    public void testGivenExistingStateRequestWhenCallGetStateThenReturnOkStatusAndProperBody() throws Exception {
        final UriComponentsBuilder uriBuilder = UriComponentsBuilder.fromPath("/uritest");

        uriBuilder.queryParam("param", "\"\\%");

        final HttpEntity<String> entity = new HttpEntity<>(null, headers);

        final URI uri = uriBuilder.build().toUri();

        testRestTemplate.exchange(uri, HttpMethod.GET, entity, String.class);
        testRestTemplate.exchange(uri.toString(), HttpMethod.GET, entity, String.class);

    }
}

Output:

"\%
%22%5C%25

There is already a closed issue about this bug: https://github.com/spring-projects/spring-boot/issues/8163

I checked the fix there and it adds a root to the URI if the URI was relative. This issue also happens if the provided string describes a relative URI. I assume the same check should be applied to all of the other methods too where the first parameter is a String instead of an URI.

[manish-pcy]

Just using new URI(enocodedUrl) in RestTemplateCall solves the issue… UriComponentsBuilder can also be used to prepare encodedUrl from MultiValueMap. Example :

String enocodedUrl = UriComponentsBuilder.fromHttpUrl(URL).queryParams(queryParameterMultiValueMap).build(true).toUriString();

restTemplate.getForEntity(new URI(enocodedUrl ) , String.class);

[georgmittendorfer]

Same issue in spring-boot 2.0.2 using UriComponentsBuilder with TestRestTemplate.

• uriBuilder.toUriString() encodes space as %2520 (it does: build(false).encode().toUriString()).
• uriBuilder.build(false).toUriString() encodes space as %20