commons-logging:commons-logging should not be a transitive dependency

Spring projects should use Spring Framework’s spring-jcl module (a dependency of spring-core) in place of commons-logging:commons-logging, however spring-data-elasticsearch pulls in commons-logging:commons-logging transitively. Can it please be excluded so that users don’t end up with two different set of Commons Logging classes on their classpath?

[sothawo]

fixed in main, 4.3.x, 4.x.2 and 4.1.x

[wilkinsona]

Excellent. Just in case it’s still useful, here’s a minimal Gradle script that shows the problem:

plugins {
	id "java"
}

group = "com.example"
version = "0.0.1-SNAPSHOT"
sourceCompatibility = "11"

repositories {
	mavenCentral()
}

dependencies {
	implementation(platform("org.springframework.data:spring-data-bom:2020.0.14"))
	implementation("org.springframework.data:spring-data-elasticsearch")
}

$ ./gradlew dependencyInsight --dependency commons-logging                                 

> Task :dependencyInsight
commons-logging:commons-logging:1.1.3
   variant "compile" [
      org.gradle.status              = release (not requested)
      org.gradle.usage               = java-api
      org.gradle.libraryelements     = jar (compatible with: classes)
      org.gradle.category            = library

      Requested attributes not found in the selected variant:
         org.gradle.dependency.bundling = external
         org.gradle.jvm.environment     = standard-jvm
         org.gradle.jvm.version         = 11
   ]

commons-logging:commons-logging:1.1.3
\--- org.elasticsearch.client:elasticsearch-rest-client:7.9.3
     +--- org.elasticsearch.client:elasticsearch-rest-high-level-client:7.9.3
     |    \--- org.springframework.data:spring-data-elasticsearch:4.1.14
     |         +--- compileClasspath (requested org.springframework.data:spring-data-elasticsearch)
     |         \--- org.springframework.data:spring-data-bom:2020.0.14
     |              \--- compileClasspath
     \--- org.elasticsearch.plugin:reindex-client:7.9.3
          \--- org.elasticsearch.client:transport:7.9.3
               \--- org.springframework.data:spring-data-elasticsearch:4.1.14 (*)

(*) - dependencies omitted (listed previously)

A web-based, searchable dependency report is available by adding the --scan option.

BUILD SUCCESSFUL in 518ms
1 actionable task: 1 executed