Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

The logic for converting values for writing is confusing and I think very wrong.

See original GitHub issue

This became obvious when analysing #1127 Part of this problem is hopefully fixed by a fix for #1089.

We have multiple checks for determining what datatype a value should get converted to and I don’t think they add to something that I understand.

BasicRelationalConverter.writeValue(@Nullable Object value, TypeInformation<?> type) converts the value twice when it is a simple type and only once otherwise. At the very least this should be refactored so I can understand why it is doing that.

Issue Analytics

State:
Created 2 years ago
Comments:5 (5 by maintainers)

Top GitHub Comments

1reaction

Mikhail2048commented, Feb 2, 2022

Yes, I think I am perfectly fine, I will try to fix this issue 😃 If I there will be some arguable questions during implementation, I will try to reach you out 😃

0reactions

schaudercommented, Feb 1, 2022

Hi Mikhail,

of course you may take a look! But as a fair warning: This is a pretty central part of Spring Data JDBC and it is perfectly possible, that we have some ideas that we don’t have properly documented yet, which could lead to a failure to accept an otherwise good PR.

If you are fine with that risk, please go ahead. And please let us know if you do so we can leave it to you at least for some time.

Top Results From Across the Web

Critical Thinking | Basic Reading and Writing - Lumen Learning

Using logic, you can evaluate ideas or claims people make, make good decisions, and form sound beliefs about the world.

Logical Fallacies - Spot a Dishonest Argument ... - Mind Tools

Discover how to identify and avoid logical fallacies and false arguments, so you can spot untruths and root out wrongful reasoning.

Logical Fallacies – Definition and Fallacy Examples

In informal fallacies, there's a problem with what you're saying, and the information might be incorrect or misleading. In this article, we'll ...

Master List of Logical Fallacies

Master List of Logical Fallacies. Fallacies are fake or deceptive arguments, "junk cognition," that is, arguments that seem irrefutable but prove nothing. ...

Types of Rhetorical Modes - Boundless Writing

There are two major strategies for answering the “why” of your thesis: arguing through logic and convincing through emotion. Argumentation. We can think...