Ordering of WebClient.filter(s) [SPR-15657]

Joe Grandja opened SPR-15657 and commented

Given this filter configuration for WebClient:

this.webClient
   .filter(filter1())
   .filter(filter2())
   .filter(filter3())
   .filter(filter4())

The expectation is that the filters would be applied in the following order: filter1, filter2, filter3, filter4. However, that is not the case, as they are applied in reverse order.

It seems a bit confusing compared to the way a Reactive stream is defined and executed in a top-down approach (the way the code reads).

Does it make sense to have the filters applied in the order they are defined - top-down approach?

---

Affects: 5.0 RC1

Issue Links:

• #20250 Simplify applying a strategy to requests from WebTestClient and WebTestClient

0 votes, 5 watchers

[spring-projects-issues]

Joe Grandja commented

Arjen, I forgot about the option of andThen for composition. This ordering is clear to me using that approach and may be what I end up using. Thanks for the tip.

[spring-projects-issues]

Arjen Poutsma commented

NPE fixed in https://github.com/spring-projects/spring-framework/commit/4f39edc9059bf3896e996224003599261412c004