[Concourse] VSCode extension doesn't understand glob patterns in group config

Describe the bug The Concourse extension in VSCode complains on glob patterns in groups configuration.

https://concourse-ci.org/pipelines.html#schema.group_config

To Reproduce

Use the sample from below. Although incomplete to be used in a real Concourse setup, it shows the error being reported clearly:

On top of that, the reverse problem of a job not being part of a group is also reported:

Sample

groups:
- name: build
  jobs:
    - "ci-*"

jobs:
- name: ci-project-one
  plan:
  - task: gradle-build
    file: gradle-build-dcind.yml

[kdvolder]

Yeah I did click there (I think) and a few other places but somehow I still cannot find any hint anywhere of using glob patterns in job names. No matter, I think I know enough from the issue ticket I dug out to make sense of it.

And about VUB… yes indeed. What a small world! 😃

[kdvolder]

This should now be fixed in latest snapshot. If you want to try it out it can be downloaded from here: http://dist.springsource.com/snapshot/STS4/nightly-distributions.html

I implemented my own simple glob pattern matcher which only supports the use of ‘*’. As it wasn’t too hard to do, it actually does support the use of multiple stars in a single pattern. Any other types of patterns are not supported. When the validation sees them it basically just assumes that it is a ‘complex’ pattern which it doesn’t know how to match. So it conservatively assumes the pattern could match anything. The effect of that is that all validation checks around these patterns will automatically pass and there will be no false errors (but also any real errors will be supressed).

More patterns could be supported in the future either by making the implementation of the glob matcher more complete or by finding some ‘good enough’ Java library that can be used to replace the simple matcher and is considered as ‘close enoungh’ in terms of supporting similar syntax as concourse’s library does.

Note: Java actually has a built-in glob matcher (https://docs.oracle.com/javase/8/docs/api/java/nio/file/PathMatcher.html). I didn’t like to use it because it seems to be intended specifically for matching file names and paths, and job names are not file names.