@RequestParam Field With Default Value Marked Required

If I have a @RequestParam field with a default value like:

@RequestParam(value = "start", defaultValue = "0") int start

Springfox will still mark this field as required in the swagger.json. Per the contract in @RequestParam:

Supplying a default value implicitly sets required() to false.

It looks like the ParameterRequiredReader should also check if the @RequestParam has a defaultValue on it and if so, not set the field to be required.

Happy to submit a PR for this if you wish.

[Mumi-aboaya]

Please read the first post. Also this is taken from the documentation:

String org.springframework.web.bind.annotation.RequestParam.defaultValue() : “\n\t\t\n\t\t\n\uE000\uE001\uE002\n\t\t\t\t\n” The default value to use as a fallback when the request parameter is not provided or has an empty value. Supplying a default value implicitly sets required to false.

Basically the code should go from: boolean missingDefaultValue = ValueConstants.DEFAULT_NONE.equals(defaultValue) || (defaultValue == null || defaultValue.length() == 0);

to: boolean missingDefaultValue = ValueConstants.DEFAULT_NONE.equals(defaultValue);

Anything other than ValueConstants.DEFAULT_NONE should be considered set by code, hence required should be set to false.

[Mumi-aboaya]

See #2296