s3bucket_path broken from 0.4.19 to 0.4.20

I couldn’t find any issue (appart the old #55) for this regression.

I run moto_server s3bucket_path -H 0.0.0.0 -p 5000.

With 0.4.19:

$ curl http://127.0.0.1:5000/            

<ListAllMyBucketsResult xmlns="http://s3.amazonaws.com/doc/2006-03-01">
  <Owner>
    <ID>bcaf1ffd86f41161ca5fb16fd081034f</ID>
    <DisplayName>webfile</DisplayName>
  </Owner>
  <Buckets>
 </Buckets>
</ListAllMyBucketsResult>

With 0.4.20:

$ curl http://127.0.0.1:5000/            

<?xml version="1.0" encoding="UTF-8"?>
  <Response>
    <Errors>
      <Error>
        <Code>NoSuchBucket</Code>
        <Message>The specified bucket does not exist</Message>
        <BucketName>127</BucketName>
      </Error>
    </Errors>
  <RequestID>7a62c49f-347e-4fc4-9331-6e8eEXAMPLE</RequestID>
</Response>

I cannot invest much time into this (right now) and just wanted to let you know about this regression (plus, 0.4.19 is working fine). So I’m sorry to be the one adding stuff to the pile without contributing…

Thank for your project! Vital for our functional tests!

[2mf]

That was introduced by commit: https://github.com/spulec/moto/commit/0535f445be4ab0edcdf8053d7396c474cb9221ba

and a terrible assumption within: host.startswith("localhost")

How can we just assume only localhost is for path based?

If you let moto run in a docker container for example…

[leplatrem]

Sorry, I think it does, now that I look at the original issue description 😃

$ curl http://127.0.0.1:5000/                                 
<ListAllMyBucketsResult xmlns="http://s3.amazonaws.com/doc/2006-03-01">
  <Owner>
    <ID>bcaf1ffd86f41161ca5fb16fd081034f</ID>
    <DisplayName>webfile</DisplayName>
  </Owner>
  <Buckets>
 </Buckets>
</ListAllMyBucketsResult>