Some FontAwesome icons do not match

Here is an minimal working example showing three problematic icons:

import sys
import qtawesome as qta
from PyQt5.QtWidgets import (QApplication, QWidget, QGridLayout,
                             QToolButton, QLabel)

app = QApplication(sys.argv)

window = QWidget()
layout = QGridLayout(window)
names = ['fa5s.grip-horizontal', 'fa5s.file-export', 'fa5s.file-import']
for i, name in enumerate(names):
    qicon = qta.icon(name, scale_factor=1.3)
    btn = QToolButton()
    btn.setIcon(qicon)
    btn.setIconSize(QSize(32, 32))
    layout.addWidget(btn, i, 0)
    layout.addWidget(QLabel(name), i, 1)
window.show()

sys.exit(app.exec_())

https://fontawesome.com/icons/grip-horizontal?style=solid https://fontawesome.com/icons/file-export?style=solid https://fontawesome.com/icons/file-import?style=solid

[CAM-Gerlach]

@darkvertex Looks like it works for me too; I commented over on the PR.

[darkvertex]

Hi there @flutefreak7 - happy to hear your government is alive again.

Should font renaming be part of a build / packaging / deploy script?

It’s not part of deployment exactly, but as part of the “update_fa5” command used for updating the FontAwesome version within the package, there is a font renaming step since PR #110 so all future updates will have unique font names.

Should we look at fixing this “upstream” by talking to the Font Awesome people?

Maybe? Here’s their repo: 👉 https://github.com/FortAwesome/Font-Awesome/issues

Edit: Or add a test that fails if the names are the same.

Actually it’s already done since PR #108.