5.1.1 : omitted indentation when pasting with the editor

Installed 5.1.1 and reset to factory defaults. Then, I created a small function:

def f():
    x = 1
    y = 2

I wanted to add another assignment just after x = 1. So, I copied that entire line and pasted it. This was the result:

def f():
    x = 1
x = 1
    y = 2

Uninstalled 5.1.1 and installed 5.0.5. Then, I reset to factory defaults and created the same small function:

def f():
    x = 1
    y = 2

Then, I copied that entire x = 1 line and pasted it. This was the result:

def f():
    x = 1
    x = 1
    y = 2

IMO, the 5.0.5 editor behaved correctly but the 5.1.1 editor neglected to paste in the indentation.

[ccordoba12]

@impact27, if the first line a user is trying to paste contains some indentation, I think we should preserve it, and adjust the indentation of all other lines according to that.

What do you think?

[sphh]

I solved this by changing the statements between https://github.com/spyder-ide/spyder/blob/48065f03dc7edb04093425032f9c69f0a26dda25/spyder/plugins/editor/widgets/codeeditor.py#L2836 and (including) https://github.com/spyder-ide/spyder/blob/48065f03dc7edb04093425032f9c69f0a26dda25/spyder/plugins/editor/widgets/codeeditor.py#L2839 to

            indentations = [
                self.get_line_indentation(line)
                for line in remaining_lines if line.strip() != ""]
            if indentations:
                max_dedent = min(indentations)
                lines_adjustment = max(lines_adjustment, -max_dedent)