DataFrames in Variable Explorer: Missings should have distinctive background color

Issue Report Checklist

• Searched the issues page for similar reports
• Read the relevant sections of the Spyder Troubleshooting Guide and followed its advice
• Reproduced the issue after updating with conda update spyder (or pip, if not using Anaconda)
• Could not reproduce inside jupyter qtconsole (if console-related)
• Tried basic troubleshooting (if a bug/error)
  • Restarted Spyder
  • Reset preferences with spyder --reset
  • Reinstalled the latest version of Anaconda
  • Tried the other applicable steps from the Troubleshooting Guide
• Completed the Problem Description, Steps to Reproduce and Version sections below

Problem Description

When opening a Pandas DataFrame with missing values in the Variable Explorer, the missings are displayed with red cell background, which is similar to the red background of the minimal values. So the missings are difficult to spot.

I suggest using a white background for the missings instead.

What steps reproduce the problem?

1. df=pd.DataFrame([1,None,5,9])
2. Open df in the Variable Explorer.

What is the expected output? What do you see instead?

I see

I expect the nan field to have a visually distinctive color, e.g. white.

Versions

• Spyder version: 3.3.1
• Python version: 3.7.0 64bits
• Qt version: Qt 5.9.3
• PyQt version: 5.9.2
• Operating System name/version: Win7 64-bit

(everything from WinPython64-3.7.0.2)

Dependencies

Available on request.

[jondo]

That’s fine. I am simply using this patch against spyder\\widgets\\variableexplorer\\dataframeeditor.py for now:

@@ -228,6 +228,8 @@ class DataFrameModel(QAbstractTableModel):
         if not self.bgcolor_enabled:
             return
         value = self.get_value(index.row(), column-1)
+        if np.isnan(value):
+            return Qt.white
         if self.max_min_col[column - 1] is None:
             color = QColor(BACKGROUND_NONNUMBER_COLOR)
             if is_text_string(value):

[jondo]

OK.

By the way, I wrote “the neutral color is already white” because I nearly could not distinguish the light grey from the white neighbor cells. Now I have found out why: I had my monitor’s contrast set too high.