Inconsistencies between the Home builtin action and the custom "start of line" shortcut action
See original GitHub issueBackground
Actions for the <kbd>Home</kbd> and <kbd>End</kbd> keys are currently hard-coded in the Editor here.
The reason for this was to provide consistency with macOS (see Issue #495), because <kbd>Home</kbd> and <kbd>End</kbd> do not corresponds to the builtin MoveToStartOfLine
and MoveToEndOfLine
shortcut in this OS, as you can see in the table below.
Later, the custom start of line
and end of line
shortcuts were added to the keyboard shortcut preferences.
Problem Description
The hard-coded action for the Home
keypress event do a Smart HOME feature (cursor is first moved at indentation position, then at the start of the line) while our custom start of line
shortcut calls a standard MoveToStartOfLine
action.
Also, I’m not sure that the hard-coded actions for Home
and End
are required anymore after the changes introduced in PR #7768.
I think we should :
- Remove the hard coded action for
Home
andEnd
in the editor. - Set the
start of line
action by default toHome
- Set the
end of line
action by default toEnd
- Do a “Smart Home” action when the
start of line
shortcut is pressed instead of a standardMoveToStartOfLine
action - Add tests to cover this.
Issue Analytics
- State:
- Created 5 years ago
- Comments:8 (8 by maintainers)
Top GitHub Comments
Your plan seems very thorough. Please go ahead with it.
Sure, no problem with that.