L003 behavior different between 0.3.6 and 0.4.0a3

I have a dbt model that looks like the following:

-- TODO: Update this model
with source_data as (
    select * from {{ source('source_name', 'xxx_yyy_zzz') }}   
)

select *
from source_data

Using sqlfluff==0.3.6 (with jinja templater) I get the following lint output:

L:   3 | P:  44 | L001 | Unneccessary trailing whitespace.

Using sqlfluff==0.4.0a3 (with jinja templater) I get the following lint output:

L:   3 | P:  44 | L001 | Unnecessary trailing whitespace.
L:   4 | P:   1 | L003 | Indentation not consistent with line #3
L:   6 | P:   1 | L003 | Indentation not consistent with line #3
L:   7 | P:   1 | L003 | Line under-indented compared to line #3

When I run sqlfluff fix on the file with 0.4.0a3 it tries to fix it to be:

-- TODO: Update this model
with source_data as (
    select * from {{ source('source_name', 'xxx_yyy_zzz') }}

)

    select *
        from source_data

This seems like unexpected behavior to me. The fix suggests that sqlfluff may be misunderstanding the indentation levels of my model.

[alanmcruickshank]

Yep - found the issue. This should be an easy fix - I’ll make a test case to catch it too.

[barrywhart]

Some thoughts on the previous comment…

My understanding of sqlfluff fix is that it’s doing two things:

• Applying fixes from those rules that implement fixes. By rules, I mean these.
• Besides the individual rules, the core of SQLFluff includes an indentation algorithm (described here) which understands SQL syntax and is generally “smart” about indenting things based on the underlying language grammar and some indentation hints embedded in the grammar. This only comes into play when a line is too long. Otherwise, it will leave things on one line.

The latter is the reason ON and AND behave as described.

I agree with the original poster; there definitely seems to be a bug here. I don’t have any intuition at this time about the cause.

A few follow-up questions:

• Can you provide your .sqlfluff file?
• I’m curious if you see similar behavior with a similar query that does not involve macros.