Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Environment variable consistency

See original GitHub issue

Some environment variables start with SQLPAD while others don’t. I’ve also noticed some are quite long, and SQLPAD_ may not be necessary.

I’d like to make these consistent, and I’m leaning towards prefixing them all with SQLPAD_ or perhaps shortening the prefix to SP_ similar to how Metabase uses MB_.

Whatever the decision, I think the existing can be supported for a version, and a deprecation warning logged. This can also coincide with deprecating JSON/INI formats.

The biggest advantage for all this is simplifying documentation. No more needing to reference keyName and KEY_NAME or SQLPAD_KEY_NAME.

Issue Analytics

State:
Created 3 years ago
Comments:8 (4 by maintainers)

Top GitHub Comments

1reaction

rickbergfalkcommented, Jul 10, 2020

Thanks for all the help renaming these @eladeyal-intel!

0reactions

rickbergfalkcommented, Jul 10, 2020

@eladeyal-intel I’ve renamed HTTPS cert/key variables since they are being left in.

I’m going to update SERVICE_TOKEN_SECRET to SQLPAD_SERVICE_TOKEN_SECRET then tag 5.1.0

Top Results From Across the Web

Defining a Consistent Environment - Java Extreme ... - O'Reilly

Any reliance on external resources, such as the CLASSPATH environment variable, opens the door for different developers to have different settings. Discussion.

What Are Environment Variables in Linux? Everything You ...

Environment variables are variables meant to be consistent across all instances of the Linux shell. When you launch a program from the shell,...

Ensure Consistency between Environment Variables during ...

I tested out your concern, and by default, there is no “consistency” between the environment variables and different jobs.

Consistent environment variables #26213 - nodejs/node

Essentially, I see the "binary invocation" as a discrete moment where ENV variables are collected and passed it to the process. They are...

10 Environment Variables Best Practices - CLIMB

Using consistent naming conventions helps to ensure that environment variables are easily identifiable and understandable.