Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Add `backported` label to PRs when running the backport tool

See original GitHub issue

How would you feel about supporting configuration that adds a label like backported to a PR once the backport PRs have been created? It’s a little misleading because the backport PRs haven’t been merged, but it’s also a good indicator as PRs have a lot more visibility (usually PRs don’t go unmerged for too long) and the status of each backport PR is usually listed at the bottom of the history for the source PR…

Thoughts?

cc @FrankHassanabad @spong

Issue Analytics

State:
Created 4 years ago
Reactions:2
Comments:6 (2 by maintainers)

Top GitHub Comments

1reaction

sqrencommented, Sep 16, 2019

@brianmcgue Yes, this is exactly how I determine which commits have been backported: Screen Shot 2019-09-16 at 14 40 20

This approach is also tells whether a backport PR has been created (grey) or merged in (green); and to which versions. I was thinking of extracting this logic, so we can have a daily job that verifies that all PRs to master are backported within 48 hours or something like it. And post a comment on the PR if a backport is missing.

@spalger I’ve created a PR that adds the option backport-created-labels (I’m open to better naming suggestions).

0reactions

brianmcguecommented, Sep 6, 2019

GitHub’s reference links are useful when it comes to this. And since each commit message in the PR references its original PR, they should always show up. But this would still be useful when filtering PRs and for quick reference checks 👍 Screen Shot 2019-09-06 at 11 01 35 AM