Feature: Provide RequestBody.create WITHOUT default charset=utf-8

• Feature Request. Start by telling us what problem you’re trying to solve. Often a solution already exists! Don’t send pull requests to implement new features without first getting our support. Sometimes we leave features out on purpose to keep the project small.

There are cases where adding charset=utf-8 breaks server-side implementations, most notably, Amazon AWS Gateway API JSON model mapping.

JSON’s default encoding is UTF-8 per https://tools.ietf.org/html/rfc7158#section-8.1 so sending an “application/json” should be equivalent to “application/json; charset=utf-8”.

Proposal:

Introduce another RequestBody.create OR modify MediaType to handle contentType=“”.

And please don’t break current work-around:

public static RequestBody create(final MediaType contentType, final byte[] content

Line 46: RequestBody.java

public static RequestBody create(MediaType contentType, String content) {
    Charset charset = Util.UTF_8;
    if (contentType != null) {
      charset = contentType.charset();
      if (charset == null) {
        charset = Util.UTF_8;
        contentType = MediaType.parse(contentType + "; charset=utf-8");
      }
    }
    byte[] bytes = content.getBytes(charset);
    return create(contentType, bytes);
}

[SoftwareArtisan]

okHttp code would be better served by using principle of “least surprise”.

In this case, a developer sets the MediaType to NADA, feeds it to RequestBody. The “least surprising” thing is the header is set as per the developers instruction not shove a charset=XXX modifier on the header - something that is NOT required by the spec.

In any case, I’ll let the issue go.

[swankjesse]

You should also ask Amazon to fix their API. Not accepting the UTF-8 charset is certainly an easy-to-fix mistake.