Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Feature Request] allow supplying a different cache key derivation function for urls

See original GitHub issue

i can understand why okhttp3.Cache is made final as mentioned in https://github.com/square/okhttp/issues/2740 , also mentioned in https://github.com/square/okhttp/issues/1459 , https://github.com/square/okhttp/issues/2261 , but i think a small change can be made to greatly increase flexibility, without changing it’s final status

that is, allow providing a different key implementation, currently it’s just a one-liner that converts a url to a string: https://github.com/square/okhttp/blob/fb284d35083e466c435565b9a1ee4092e322cc83/okhttp/src/main/java/okhttp3/Cache.java#L186 i believe adding a option to change it is easy, possibly using the builder pattern, and won’t require change to any other components

Issue Analytics

State:
Created 6 years ago
Reactions:4
Comments:8 (4 by maintainers)

Top GitHub Comments

1reaction

swankjessecommented, Mar 21, 2019

That is strange, how does it work with browsers where caches aren’t configurable?

The URL is a really awesome cache key, and URLs should be designed with caching in mind. You should use path & query for data that impacts caching (userId), and headers for things that don’t (signature).

If your server developers didn’t do this, they should! It’ll improve caching on every HTTP client.

0reactions

yschimkecommented, Mar 29, 2020

Won’t fix.