java.lang.NullPointerException in CacheControl

Fatal Exception: java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.String.equalsIgnoreCase(java.lang.String)' on a null object reference
       at okhttp3.CacheControl.parse(CacheControl.java:173)
       at okhttp3.Request.cacheControl(Request.java:83)
       at okhttp3.internal.cache.CacheStrategy$Factory.get(CacheStrategy.java:175)
       at okhttp3.internal.cache.CacheInterceptor.intercept(CacheInterceptor.java:59)
       at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:147)
       at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:121)
       at okhttp3.internal.http.BridgeInterceptor.intercept(BridgeInterceptor.java:93)
       at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:147)
       at okhttp3.internal.http.RetryAndFollowUpInterceptor.intercept(RetryAndFollowUpInterceptor.java:125)
       at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:147)
       at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:121)
       at okhttp3.RealCall.getResponseWithInterceptorChain(RealCall.java:200)
       at okhttp3.RealCall$AsyncCall.execute(RealCall.java:147)
       at okhttp3.internal.NamedRunnable.run(NamedRunnable.java:32)
       at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
       at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
       at java.lang.Thread.run(Thread.java:761)

I had the exception in fabric. I check my project code, it may be found using a single instance of each request, I’m not too sure.

This is the official demo.

private final OkHttpClient client = new OkHttpClient();
 Request request = new Request.Builder() 
        .url("https://api.github.com/markdown/raw")
        .post(RequestBody.create(MEDIA_TYPE_MARKDOWN, postBody))
        .build();
    try (Response response = client.newCall(request).execute()) {
      if (!response.isSuccessful()) throw new IOException("Unexpected code " + response);

      Headers responseHeaders = response.headers();
      for (int i = 0; i < responseHeaders.size(); i++) {
        System.out.println(responseHeaders.name(i) + ": " + responseHeaders.value(i));
      }
      System.out.println(response.body().string());
    }

and i replace new Request.Builder() to getRequestBuilder().

 private static Request.Builder requestBuilder;
  public synchronized Request.Builder getRequestBuilder() {
        if (requestBuilder == null) {
            requestBuilder = new Request.Builder();
        }
        return requestBuilder;
    }

and I want to sure the Request object can use a Singleton Pattern when run request.Ths.

[yschimke]

I suspect from the original report, “new Request.Builder() to getRequestBuilder()” the Request.Builder is being reused, probably in multiple threads? Are you creating a fresh Request.Builder on each request?

[ferdinandtaishev]

got this issue in 4.9.1 okhttp version. also we have null pointer in Http1ExchangeCodec. It seems to be the same problem with null header key