Must-revalidate does not revalidate

I have an i ssue where OkHttp does not revalidate requests. (3.10.0) If the cache-control says “must-revalidate”, the request should be revalidated.

In that case, the CacheStrategy should return a not null network request:

@Test
fun shouldRevalidate() {
  val nowMillis = 1527845183942 // =Fri Jun 01 2018 09:26:23
  val request = Request.Builder()
      .method("GET", null)
      .url("https://my.url.com/v1/item/d002fbef-7061-4d92-9958-7b128cf85855")
      .build()

  val handshake = Handshake.get(
      TlsVersion.TLS_1_2,
      CipherSuite.TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384, emptyList(), emptyList()
  )
  val cacheCandidate = Response.Builder()
      .code(200)
      .addHeader("date", "Fri, 01 Jun 2018 07:45:40 GMT")
      .addHeader("cache-control", "private, must-revalidate")
      .addHeader("last-modified", "Thu, 31 May 2018 08:04:53 GMT")
      .sentRequestAtMillis(1527839142145) //=Fri Jun 01 2018 07:45:42
      .receivedResponseAtMillis(1527839142295)  //=Fri Jun 01 2018 07:45:42 
      .request(request)
      .protocol(Protocol.HTTP_1_1)
      .handshake(handshake)
      .message("")
      .build()

  val cacheStrategy = CacheStrategy.Factory(nowMillis, request, cacheCandidate)
      .get()
  assertThat(cacheStrategy.networkRequest).isNotNull()
}

[yschimke]

My understanding is that this flag means when cached and not stale, normal caching rules can be used. When cached but stale, clients and the cache can’t override the stale checks and use the cache results. is that your understanding?

[yschimke]

One small note: OkHttpClient.Builder().build() without replacing an existing client isn’t doing anything.