Provide a JUnit 5 extension for MockWebServer

I’m trying to get rid of JUnit 4 in my project and the last remaining bit is MockWebServer which depends on org.junit.rules.ExternalResource.

That is not a blocker as org.junit.jupiter:junit-jupiter-migrationsupport provides experimental support for this.

However, it would be great to provide an implementation of MockWebServer following the Junit 5 extension model.

[JakeWharton]

Yeah we need to just break this in OkHttp 4 and decouple the need for a server from the idea that you’re inside a test runner.

On Sat, Mar 2, 2019, 3:39 PM Jesse Wilson <[e-mail] wrote:

Also – we should assume there will be another incompatible library called JUnit 6 in a few years.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/square/okhttp/issues/4667#issuecomment-468958019, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEEEboweT8OBwWc_PSnR0K4-hGQiqn0ks5vSuGWgaJpZM4bUX4X .

[wbervoets]

is a different square project for it planned?

MockWebserver probably isn’t considered a top level public API, and upgrading this is awkward. Best fix is probably a lift and shift and API refactor under a different square project.