Recover gracefully from corrupted cache

In an application using Retrofit 2.2.0 and OkHttp 3.6.0, I’m getting several crashes per day with a strange error inside OkHttp classes, which I can’t catch because I’m using async calls.

Fatal Exception: java.lang.IllegalArgumentException: unexpected url: ://example.com/api/recommend/Ans%20
       at okhttp3.Request$Builder.url(Request.java:141)
       at okhttp3.Cache$Entry.response(Cache.java:705)
       at okhttp3.Cache.get(Cache.java:210)
       at okhttp3.Cache$1.get(Cache.java:144)
       at okhttp3.internal.cache.CacheInterceptor.intercept(CacheInterceptor.java:70)
       at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:92)
       at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:67)
       at okhttp3.internal.http.BridgeInterceptor.intercept(BridgeInterceptor.java:93)
       at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:92)
       at okhttp3.internal.http.RetryAndFollowUpInterceptor.intercept(RetryAndFollowUpInterceptor.java:124)
       at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:92)
       at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:67)
       at okhttp3.RealCall.getResponseWithInterceptorChain(RealCall.java:170)
       at okhttp3.RealCall.access$100(RealCall.java:33)
       at okhttp3.RealCall$AsyncCall.execute(RealCall.java:120)
       at okhttp3.internal.NamedRunnable.run(NamedRunnable.java:32)
       at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1113)
       at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:588)
       at java.lang.Thread.run(Thread.java:833)

I guess what’s happening is the cache is somehow corrupted (the URL scheme is missing), and when the CacheInterceptor tries to create an HttpUrl, this exception gets thrown, and since it’s not an IOException, it’s not caught and given to my failure handler.

Shouldn’t such RuntimeExceptions be caught by RealCall and wrapped in an IOException for delivery to the failure handler?

[hugosvent]

any workaround on handling this issue?

got so many crash because of Fatal Exception: java.lang.IllegalArgumentException Expected URL scheme 'http' or 'https' but no colon was found

should I just add an Interceptor which try the builder and catch the IllegalArgumentException then force it into network instead of cache by using cacheControl(FORCE_NETWORK)?

it’s so hard to reproduce it internally

[swankjesse]

Yeah, we should definitely recover better when the cache breaks badly.