Redirect 302 IllegalArgumentException without workaround java.lang.IllegalArgumentException: Unexpected char 0xf6 at 53 in header value

So say I’m looking for a random reddit post via something like: https://www.reddit.com/r/EarthPorn/random/.json

And I get a 302 redirect to something like: https://www.reddit.com/r/EarthPorn/comments/3viwq1/mjölkeviken_sweden_3246x2448_oc/.json which gets stored in the “Location” header.

Notice the umlaut. It causes the IllegalArgumentException.

So I see that this was announced as part of the 2.5 release: “OkHttp now rejects request headers that contain invalid characters”. And I think that is good as default behavior but it would be nice to be able to sanitize the headers before the request chain is errored out completely.

I can’t use a network interceptor to solve this problem:

    client.networkInterceptors().add(object : Interceptor {
            override fun intercept(chain: Interceptor.Chain?): Response? {
                var req = chain?.request()
               //The request headers are all valid
                return chain?.proceed(req)?.let { //BOOM!!! The crash happens in proceed
                    //This is where we would fix the headers if we could
                    it
                }
            }
        })

My stack trace looks like:

 fail
 java.lang.IllegalArgumentException: Unexpected char 0xf6 at 53 in header value: https://www.reddit.com/r/EarthPorn/comments/3viwq1/mjölkeviken_sweden_3246x2448_oc/.json
    at com.squareup.okhttp.Headers$Builder.checkNameAndValue(Headers.java:295)
    at com.squareup.okhttp.Headers$Builder.add(Headers.java:245)
    at com.squareup.okhttp.internal.http.FramedTransport.readSpdy3HeadersList(FramedTransport.java:229)
    at com.squareup.okhttp.internal.http.FramedTransport.readResponseHeaders(FramedTransport.java:142)
    at com.squareup.okhttp.internal.http.HttpEngine.readNetworkResponse(HttpEngine.java:909)
    at com.squareup.okhttp.internal.http.HttpEngine.access$300(HttpEngine.java:93)
    at com.squareup.okhttp.internal.http.HttpEngine$NetworkInterceptorChain.proceed(HttpEngine.java:894)
    at com.hotpodata.baconforkotlin.RedditSessionService$genService$1.intercept(RedditSessionService.kt:73)

[swankjesse]

Yup, real problem. Will fix.

[swankjesse]

Fixed by: https://github.com/square/okhttp/pull/2587