Unexpected connection leak message in 3.0.0-RC1

I’m using the published 3.0.0-RC1.

I’m seeing this message:

WARNING: A connection to https://api.push.apple.com/ was leaked. Did you forget to close a response body?
Jan 08, 2016 8:23:58 PM okhttp3.ConnectionPool pruneAndGetAllocationCount

Over and over.

My code looks like this:

    client.newCall(request).enqueue(new Callback() {
      override def onFailure(request: Request, throwable: IOException) {
      }

      override def onResponse(response: Response) {
        if (!response.isSuccessful()) {
          val body = response.body()
          val charStream = body.charStream()
          val reason = GSON.fromJson(charStream, classOf[APNSError])
          body.close()
        }
      }
    })

(Note that the example Gson recipe leaks the body there, but this doesn’t.)

Do I need to close the body in the successful case even if I’m not reading it?

Thanks!

[omarkilani]

Alright – I think the docs could be clearer here. 😃

None of these https://github.com/square/okhttp/wiki/Recipes call close.

[JakeWharton]

Retrofit closes it for you

On Sat, Jun 10, 2017 at 6:55 PM Etienne Lawlor [e-mail] wrote:

Instead of having a Retrofit Service interface which returns Call mine returns Observable. I am using RxJava and calling observable.subscribe(). Where would be the correct place to close the response body?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/square/okhttp/issues/2217#issuecomment-307594888, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEEEXT3pTH-9ea7ogjuw49MliPNbiYCks5sCx7FgaJpZM4HBcqs .