When Authenticator.authenticate() throws an exception the StreamAllocator isn't released

First of all sorry for not providing a failing test here, but I struggled to do that for this case.

I was just implementing an Authenticator when I found that when Authenticator.authenticate() throws an exception (it has a catched IOException in its signature, so that seems to be an expected case) the RetryAndFollowUpInterceptor will never release its StreamAllocation - as opposed to when returning null in authenticate().

Here are the according lines in the RetryAndFollowUpInterceptor:

Request followUp = followUpRequest(response, streamAllocation.route());

if (followUp == null) {
    if (!forWebSocket) {
      streamAllocation.release();
    }
    return response;
}

Shouldn’t there be a try catch around the call to followUpRequest() to handle that case and and then re-throw the exception?

[CMahesh]

https://github.com/square/okhttp/pull/3885

changes commited and pull request created.

[CMahesh]

I am new to open source community. Can I work it ?