Generate code to support JSON serializing/deserializing as well?

In my company, we want to use wire-generated java code to support json deserialization by adding extra jackson annotations (like @JsonCreator, @JsonProperty and so on) so we made some changes in the wire’s code. I want to check if this is something that wire wants to support because it’s such a common use case that protobuf is introduced later into an json-driven legacy system. If yes I can clean up the code a bit to perhaps add an extra flag like --support-json for that functionality and make a pull request. Thanks.

[vanvlack]

+1 to extensibility over including directly. Ideally, I could create a MessageWriter of my own, that generates pojo’s how I would like, including the proto bits (or not for that matter).

[JakeWharton]

It is intended to be looked at, though, and we value code that looks like it was written by a person.

On Wed, Feb 14, 2018 at 5:11 PM Shadow Man [e-mail] wrote:

While I agree that qualifying all class names is not something you want to do in manually generated classes, I would also argue that qualified names are not an issue in auto-generated code that isn’t intended to be modified. In fact, it may be seen as a benefit, because now you know right away where that class comes from and why you’re IDE is telling you that “List” is not a “List”.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/square/wire/issues/231#issuecomment-365761908, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEEEc-keJqlvJ24szAAHc7X16A1O-lUks5tU1oIgaJpZM4FRyeH .